Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how extensions can manage cluster/workspace stores #1176

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Improve how extensions can manage cluster/workspace stores #1176

merged 5 commits into from
Oct 30, 2020

Conversation

jakolehm
Copy link
Contributor

  • extension can claim workspace/cluster to be managed by them
  • lens only shows workspaces/clusters that are explicitly set as activated (they are not activated automatically, except locally managed objects)
  • workspace/cluster store api cleanup (unify few method calls)

@jakolehm
improve how extensions can manage cluster/workspace stores
4dd6d58 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added enhancement New feature or request area/extension Something to related to the extension api labels Oct 29, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Oct 29, 2020
@jakolehm jakolehm requested a review from a team October 29, 2020 15:19
ixrock
ixrock approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@ixrock ixrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ixrock
Copy link
Contributor

ixrock commented Oct 29, 2020

Found a bug, active-cluster icon for some reasons don't get updated, please check.
image

@jakolehm
fixes
205864f 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
jakolehm
jakolehm commented Oct 29, 2020
View reviewed changes
Copy link
Contributor Author

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug, active-cluster icon for some reasons don't get updated, please check.

Noticed the same.. not sure why this does not update (renderer does get update via ipc) 🤔

@jakolehm
Copy link
Contributor Author

Found a bug, active-cluster icon for some reasons don't get updated, please check.

Bug seems to be in ClustersMenu, it does not properly react to store changes. Will fix asap.

@jakolehm
fixes
a068230 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
fixes
614bf4e 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
expose more from workspace store
505ba8d 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
Copy link
Contributor Author

@nevalla @ixrock PTAL

nevalla
nevalla approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit 4a65539 into master Oct 30, 2020
@jakolehm jakolehm deleted the extension-managed-cluster-and-workspace branch October 30, 2020 07:45
@jakolehm jakolehm mentioned this pull request Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixrock ixrock ixrock approved these changes

@nevalla nevalla nevalla approved these changes

Assignees
No one assigned
Labels
area/extension Something to related to the extension api enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jakolehm @ixrock @nevalla