Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chart details when selecting another chart #1155

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Update chart details when selecting another chart #1155

merged 1 commit into from
Nov 3, 2020

Conversation

pashevskii
Copy link
Contributor

@pashevskii pashevskii commented Oct 27, 2020 •
edited by aleksfront
Loading

Fixed #1156

@nevalla nevalla added the bug Something isn't working label Oct 27, 2020
@nevalla nevalla changed the title [BugFix] Chart details are not updated on selecting another chart Update chart details when selecting another chart Oct 27, 2020
@nevalla nevalla requested a review from aleksfront October 27, 2020 13:06
@pashevskii pashevskii mentioned this pull request Oct 27, 2020
Closed
@pashevskii
Copy link
Contributor Author

Related Issue #1156

@pashevskii pashevskii force-pushed the updating-charts branch 2 times, most recently from 3f1a5c1 to f760cac Compare November 3, 2020 11:25
@pashevskii pashevskii requested a review from aleksfront November 3, 2020 11:47
@pashevskii
[BugFix] Chart details are not updated on selecting another chart
8a62521 
Signed-off-by: Pavel Ashevskii <pashevskii@mirantis.com>
aleksfront
aleksfront approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aleksfront aleksfront merged commit 0497947 into lensapp:master Nov 3, 2020
@nevalla nevalla mentioned this pull request Nov 4, 2020
Merged
@pashevskii pashevskii deleted the updating-charts branch December 7, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksfront aleksfront aleksfront approved these changes

Assignees
No one assigned
Labels
area/ui bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart detailed information was not updated
3 participants
@pashevskii @aleksfront @nevalla