[cherry-pick] Fetch Helm available repositories from Artifact HUB cache #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
nevalla
changed the title
jim-docker
approved these changes
Oct 23, 2020
jim-docker
reviewed
Oct 23, 2020
| @@ -37,12 +37,12 @@ export class HelmRepoManager extends Singleton { | |||
|
|
|||
| async loadAvailableRepos(): Promise<HelmRepo[]> { | |||
| const res = await customRequestPromise({ | |||
| uri: "https://hub.helm.sh/assets/js/repos.json", | |||
There was a problem hiding this comment.
BTW this previous uri seems to be working again
There was a problem hiding this comment.
nvm, it doesn't work. Stale build, still had the new uri.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #1090 to
v3.6Signed-off-by: Lauri Nevala lauri.nevala@gmail.com