Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adding support page #1030

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

jim-docker
Copy link
Contributor

@jim-docker jim-docker commented Oct 6, 2020

Signed-off-by: Jim Ehrismann jehrismann@mirantis.com

  • define actual content of support page
  • rework it as an extension

image

addresses #742

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Comment on lines +1 to +66
.Support {
position: fixed!important; // Allows to cover ClustersMenu
z-index: 1;

.WizardLayout {
grid-template-columns: unset;
grid-template-rows: 76px 1fr;
padding: 0;

.content-col {
padding: $padding * 8 0;
background-color: $clusterSettingsBackground;

h2 {
margin-bottom: $margin * 2;

&:not(:first-child) {
margin-top: $margin * 3;
}
}

.SubTitle {
text-transform: none;
margin: 0!important;
}

.repos {
position: relative;

.Badge {
display: flex;
margin: 0;
margin-bottom: 1px;
padding: $padding $padding * 2;
}
}

.hint {
margin-top: -$margin;
}
}

span.supportLink {
cursor: pointer;
color: $primary;
text-decoration: underline;
position: relative;
}
}

.is-mac & {
.WizardLayout .head-col {
padding-top: 32px;
overflow: hidden;

.Icon {
margin-top: -$margin * 2;
}
}
}

.Select {
&__control {
box-shadow: 0 0 0 1px $borderFaintColor;
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy/pasted from preferences, will pare it down when page is finalized

<div id="support" className="flex gaps align-center box right">
<Icon
small
svg="support"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this icon is listed on the material-design-icons website but is not present in the npm repo. There are reports of other icons missing and this repo not being maintained. Have we considered fontawesome instead?

Copy link
Contributor

@ixrock ixrock Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we should manage latest updates of material-icons-font in our repo or consider to switch to another icon-font library with active maintainers.

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
@ixrock ixrock changed the base branch from master to extension_support_page October 19, 2020 11:23
@ixrock ixrock marked this pull request as ready for review October 19, 2020 11:24
@ixrock ixrock merged commit 36cc10d into lensapp:extension_support_page Oct 19, 2020
@ixrock
Copy link
Contributor

ixrock commented Oct 19, 2020

Moved to lensapp:extension_support_page to continue work as an extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants