Fix cluster dashboard opening and state refreshing #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
nevalla
commented
Oct 1, 2020
| @@ -110,7 +111,7 @@ export class Cluster implements ClusterModel { | |||
|
|
|||
| protected bindEvents() { | |||
| logger.info(`[CLUSTER]: bind events`, this.getMeta()); | |||
| const refreshTimer = setInterval(() => this.online && this.refresh(), 30000); // every 30s | |||
| const refreshTimer = setInterval(() => !this.disconnected && this.refresh(), 30000); // every 30s | |||
There was a problem hiding this comment.
We want to refresh connection status even when cluster is offline/not accessible, to get dashboard opened automatically when the connection comes back online.
nevalla
commented
Oct 1, 2020
| @@ -44,8 +44,8 @@ export class App extends React.Component { | |||
| const clusterId = getHostedClusterId(); | |||
| logger.info(`[APP]: Init dashboard, clusterId=${clusterId}, frameId=${frameId}`) | |||
| await Terminal.preloadFonts() | |||
| await clusterIpc.activate.invokeFromRenderer(clusterId, frameId); | |||
| await getHostedCluster().whenReady; // cluster.refresh() is done at this point | |||
| await clusterIpc.setFrameId.invokeFromRenderer(clusterId, frameId); | |||
There was a problem hiding this comment.
ClusterStatus component will activate the cluster so at this point we only need to sync frame id.
nevalla
added a commit
that referenced
this pull request
Oct 1, 2020
* Fix cluster dashboard opening and state refreshing Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
Nokel81
pushed a commit
to Nokel81/lens
that referenced
this pull request
Oct 1, 2020
* Fix cluster dashboard opening and state refreshing Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
nevalla
added a commit
that referenced
this pull request
Oct 2, 2020
* Fix cluster dashboard opening and state refreshing (#1006) Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes cluster dashboard opening so that auth proxy is not opened multiple times. Also cluster state is refreshed now also when cluster is not accessible/online, to automatically get cluster dashboard back when the cluster connection comes back.
Cluster overview does not try to refresh events and metrics anymore if cluster is not available.
Signed-off-by: Lauri Nevala lauri.nevala@gmail.com