Cleanup tests to fix type errors and use tables

Signed-off-by: Sebastian Malton <sebastian@malton.name>
lensapp · Mar 13, 2023 · 7c48248 · 7c48248
1 parent a99e922
commit 7c48248
Show file tree

Hide file tree

Showing 2 changed files with 194 additions and 309 deletions.
diff --git a/packages/core/src/common/cluster/create-request-namespace-list-permissions.injectable.ts b/packages/core/src/common/cluster/create-request-namespace-list-permissions.injectable.ts
@@ -39,18 +39,12 @@ const createRequestNamespaceListPermissionsInjectable = getInjectable({
 
         const { resourceRules } = status;
 
-        return (resource) => {
-          const rules = resourceRules.filter(({
-            apiGroups = ["*"], resources = ["*"],
-          }) => {
-            const isAboutRelevantApiGroup = apiGroups.includes("*") || apiGroups.includes(resource.group);
-            const isAboutResource = resources.includes("*") || resources.includes(resource.apiName);
-
-            return isAboutRelevantApiGroup && isAboutResource;
-          });
-
-          return rules.some(({ verbs }) => verbs.includes("*") || verbs.includes("list"));
-        };
+        return (resource) => (
+          resourceRules
+            .filter(({ apiGroups = ["*"] }) => apiGroups.includes("*") || apiGroups.includes(resource.group))
+            .filter(({ resources = ["*"] }) => resources.includes("*") || resources.includes(resource.apiName))
+            .some(({ verbs }) => verbs.includes("*") || verbs.includes("list"))
+        );
       } catch (error) {
         logger.error(`[AUTHORIZATION-NAMESPACE-REVIEW]: failed to create subject rules review`, { namespace, error });