Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react: enable useLinkHandle and useUnlinkHandle hooks #628

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Oct 20, 2023

  • API error when unlinking not-linked handle is not propagated to the error returned from hook
    • solved with preventing submitting a mutation that could cause API error
  • API should include more data in the response from ownedHandles to build meaningful UI https://avara.height.app/T-17101
    • done
  • add an optimistic update
    • done
  • figure out why updateProfileCache doesn't include new handle
    • done

@height
Copy link

height bot commented Oct 20, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: f771741

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@lens-protocol/api-bindings Minor
@lens-protocol/domain Minor
@lens-protocol/react Minor
@lens-protocol/react-web Minor
react-v1 Patch
api-bindings-v1 Patch
@lens-protocol/blockchain-bindings Patch
@lens-protocol/wagmi Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Oct 31, 2023 10:14am

@krzysu krzysu marked this pull request as ready for review October 27, 2023 11:56
@krzysu krzysu requested a review from cesarenaldi October 27, 2023 12:34
@krzysu krzysu merged commit 9490db8 into lens-v2 Oct 31, 2023
1 check passed
@krzysu krzysu deleted the v2/link-handle-2 branch October 31, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant