Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: remove forApps from config to avoid confusion #554

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Oct 2, 2023

forApps was not doing what was described in the config, forApps has to be provided as part of a request object in each query

@height
Copy link

height bot commented Oct 2, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

🦋 Changeset detected

Latest commit: 765af1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lens-protocol/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Oct 4, 2023 11:08am

@krzysu krzysu force-pushed the client-remove-for-apps branch from 13f3da9 to 765af1a Compare October 4, 2023 11:07
@krzysu krzysu requested a review from cesarenaldi October 4, 2023 11:07
@krzysu krzysu merged commit f31c4e8 into lens-v2 Oct 4, 2023
1 check passed
@krzysu krzysu deleted the client-remove-for-apps branch October 4, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant