Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add examples web app to test v2 hooks #550

Merged
merged 2 commits into from
Sep 28, 2023
Merged

add examples web app to test v2 hooks #550

merged 2 commits into from
Sep 28, 2023

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Sep 28, 2023

No description provided.

@height
Copy link

height bot commented Sep 28, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e7f896d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Sep 28, 2023 2:43pm

reecejohnson
reecejohnson approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@reecejohnson reecejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, two small comments 🙏

examples/web/README.md Outdated
@@ -0,0 +1,15 @@
# Lens SDK + wagmi + Bundlr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe note here that the example is using ethers as well

people may be looking for a viem example so being explicit about which tool here would be useful

examples/web/src/App.tsx Outdated
});

const lensConfig: LensConfig = {
// bindings: wagmiBindings(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still needed?

@krzysu krzysu merged commit 422d8da into lens-v2 Sep 28, 2023
@krzysu krzysu deleted the v2/examples-web branch September 28, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reecejohnson reecejohnson reecejohnson approved these changes

@cesarenaldi cesarenaldi Awaiting requested review from cesarenaldi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysu @reecejohnson