Refactor Downloader & testing #245
Conversation
lenguyenthanh
force-pushed
the
parser-testing
branch
from
8f84090 to
b524fed
Compare
lenguyenthanh
force-pushed
the
parser-testing
branch
from
b524fed to
a9704c9
Compare
| .through(fs2.text.lines) | ||
| .drop(1) // first line is header | ||
| .evalMap(parseLine) | ||
| .collect { case Some(x) => x } |
There was a problem hiding this comment.
There was a problem hiding this comment.
you have such sharp eyes, thanks!
| .map(x => x._2) | ||
| .fold[Set[FederationId]](Set.empty)((acc, x) => acc ++ x.map(_.id)) |
There was a problem hiding this comment.
Is this
.mapFilter(x => x._2.map(_.id))
.compile
.to(Set)less preferable?
There was a problem hiding this comment.
This change also eliminates .last part, I guess
There was a problem hiding this comment.
couldn't use mapFilter, probably IO is not a FunctorFilter, so this is the best I came up with: 3010f83. thanks again, really love your reviews!
There was a problem hiding this comment.
Yep, looks great 👍🏻 (I haven't been sure if .to(Set) works). But I suppose mapFilter works here, because there is no bound for F[_] for Stream[F[_], A].mapFilter, scastie for reference
There was a problem hiding this comment.
oh, it was me, I forgot to import cats.syntax.all.* 🤦
There was a problem hiding this comment.
| .evalMap(parseLine) | ||
| .collect { case Some(x) => x } |
There was a problem hiding this comment.
We can shorten it to just .evalMapFilter(parseLine) (source)
There was a problem hiding this comment.
Split database update from Downloader, which makes the concern clearer
which in turns makes testing easier.