Filter out rating that lower than 1400

fix #253
lenguyenthanh · Feb 1, 2025 · fb3f3db · fb3f3db
1 parent 9f0962c
commit fb3f3db
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/modules/crawler/src/test/scala/ParserTest.scala b/modules/crawler/src/test/scala/ParserTest.scala
@@ -28,7 +28,18 @@ object ParserTest extends SimpleIOSuite:
     )
     lines
       .traverse(parse)
-      .map(_.flatten.map(_.active))
+      .map(_.flatMap(_.map(_.active)))
       .map(x => expect(x == List(false, false, true, true)))
 
+  test("rating constraints"):
+    val lines = List(
+      "10001492       Ojok, Patrick                                                UGA M             FI,LSI             900  0   20 1932  0   20 1926  0   20 1974      ",
+      "10001492       Ojok, Patrick                                                UGA M             FI,LSI             4002  0   20 1932  0   20 1926  0   20 1974      ",
+      "10001492       Ojok, Patrick                                                UGA M             FI,LSI             2700  0   20 1932  0   20 1926  0   20 1974      "
+    )
+    lines
+      .traverse(parse)
+      .map(_.flatMap(_.flatMap(_.standard)))
+      .map(x => expect(x == List(2700)))
+
   private def parse(s: String) = Downloader.parse(s).map(_.map(_._1))
diff --git a/modules/types/src/main/scala/Rating.scala b/modules/types/src/main/scala/Rating.scala
@@ -4,7 +4,7 @@ import cats.syntax.all.*
 import io.github.iltotore.iron.*
 import io.github.iltotore.iron.constraint.all.*
 
-type RatingConstraint     = GreaterEqual[0] & LessEqual[4000]
+type RatingConstraint     = GreaterEqual[1400] & LessEqual[4000]
 opaque type Rating <: Int = Int :| RatingConstraint
 
 object Rating extends RefinedTypeOps[Int, RatingConstraint, Rating]: