You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make default_parser() part of the public API, because it's useful stand-alone, especially if we get a magic+ parser (#222), XML sanitization (#212), or enhanced HTML sanitization (#227).
Initially, we can expose just the callable part of the parser by wrapping the parser object in a function with the same signature:
A question related to this: Should we allow custom parsers to store custom caching metadata? For instance, #222 might need to store one header per page. Type annotations are not stable, we can turn the TypedDict into a regular dict later.
Based on the signature above, ParsedFeed and all its components must become public / stable as well (i.e. FeedData, EntryData, their hash property). Also, ParsedFeed should probably not be a named tuple anymore.
The text was updated successfully, but these errors were encountered:
Make default_parser() part of the public API, because it's useful stand-alone, especially if we get a
magic+
parser (#222), XML sanitization (#212), or enhanced HTML sanitization (#227).Initially, we can expose just the callable part of the parser by wrapping the parser object in a function with the same signature:
Because this is a new feature, feed_root should default to None (no filesystem access).
It may be nice to wrap the cache validation headers in a typed dict (although I don't like "cache_validators" as a name):
A question related to this: Should we allow custom parsers to store custom caching metadata? For instance, #222 might need to store one header per page. Type annotations are not stable, we can turn the TypedDict into a regular dict later.
Based on the signature above, ParsedFeed and all its components must become public / stable as well (i.e. FeedData, EntryData, their
hash
property). Also, ParsedFeed should probably not be a named tuple anymore.The text was updated successfully, but these errors were encountered: