Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sourcesContent to dist/data-grid.css.map #9

Merged
merged 1 commit into from
May 11, 2023

Conversation

jackkjhsu
Copy link
Contributor

Hi Thomas,

I noticed the sourcesContent was missing from dist/data-grid.css.map. So I updated the corresponding scripts on package.json to include it. I also updated my local npm packages and rebuilt all my local files and found some discrepancies in the data-grid*.js.map files between yours and mine. I believe the differences are in the way the carriage return characters are generated. Yours has less \r\n than mine. Theoretically, the maps generated between yours and mine should be identical. I'm not sure if it really matter as these files are just maps.

Thanks again.

@lekoala
Copy link
Owner

lekoala commented May 11, 2023

@jackkjhsu my new policy is to not generate map files anymore anyway for minified files :-) they tend to get in the way, most of the time they reference .scss files that are not deployed and therefore not very useful

@lekoala lekoala merged commit f9e6745 into lekoala:master May 11, 2023
@jackkjhsu
Copy link
Contributor Author

Hi Thomas,

As you probably noticed that I updated the npm scripts only for the data-grid.css* files and left the min files as-is.

Thanks for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants