Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save-state plugin #17

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Add save-state plugin #17

merged 3 commits into from
Nov 18, 2024

Conversation

fiztech-code
Copy link
Contributor

A new plugin, save-state, has been implemented to store the current filter, sorting, and paging settings of the data grid.

@lekoala lekoala merged commit a2d3508 into lekoala:master Nov 18, 2024
@lekoala
Copy link
Owner

lekoala commented Nov 18, 2024

@fiztech-code @jackkjhsu i've merged the code
i've also added biome as a baseline for code quality
i've updated everything it should work fine
i also noticed i wasn't importing the Options typedef and therefore missed a few typos. now it should be all good

if you can review that all works as expected, that would be great

@fiztech-code
Copy link
Contributor Author

fiztech-code commented Nov 18, 2024

i found small type-o on line.29 in save-state.js

line.10 /utils/appendParamsToUrl.js
Number.isNaN is behaving differently from isNaN

lastly, i experienced issues with for(){} in chromium browsers ( Chrome & Edge ) with dev-tools opened yielding Error code: STATUS_BREAKPOINT
no issues with Array.prototype.forEach()

@jackkjhsu

@lekoala
Copy link
Owner

lekoala commented Nov 20, 2024

@fiztech-code good catch, i've updated, i added a typedef to avoid any typo in the future

i don't seem to have any issue with for loops, do you have some kind of breakpoints configured?
https://developer.chrome.com/docs/devtools/javascript/breakpoints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants