Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes #16

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Some minor fixes #16

merged 3 commits into from
Sep 13, 2024

Conversation

jackkjhsu
Copy link
Contributor

Hi Thomas,

I just pushed some changes for some minor fixes. Most notably, an issue with the footer width resizing when hiding or showing columns using the context menu. This issue only occurs on Chrome and Edge that seems to have something to do with how the browser renders the flexbox. I tried fixing it with css but couldn't get any of the css fixes I tried to work. Fortunately, the fixPage method works to address the Chrome rendering issue.

I also updated the npm packages and got some css build deprecation warnings from the latest version of sass. So I reverted to v1.77.6 without making more changes to get rid of the warning.

Please let me know if the changes are ok.

Thanks Thomas

@lekoala lekoala merged commit f96b78f into lekoala:master Sep 13, 2024
1 check passed
@jackkjhsu
Copy link
Contributor Author

Thanks Thomas 👍

@jackkjhsu
Copy link
Contributor Author

Hi Thomas,
A colleague of mine Nik Kojevnikov (@fiztech-code) just completed a plugin for caching various states of data-grid (i.e. page number, sorted column, etc). We have tested this plugin (save-state.js) together, and he'll be making a pull request for it soon. I hope this is ok with you.
Aside from the new plugin, I also have a few changes coming up. But I will do it with another pull request of my own.

Thank you Thomas

@lekoala
Copy link
Owner

lekoala commented Nov 15, 2024

sure, he's welcome and i'm happy to review it

@jackkjhsu
Copy link
Contributor Author

Thank you very much Thomas! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants