feat: single-quoted attribute value syntax support #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @leizongmin!
First of all thank you for creating this package. We have been using it for sanitizing html and put it inside JSON files. It can be done in two ways:
{ "html": "<a href=\"#\">Hello</a>" }
{ "html": "<a href='#'>Hello</a>" }
but the default config output is:
{ "html": "<a href="#">Hello</a>" }
We would like to use default config and don't create any custom rules via
safeAttrValue
oronIgnoreTagAttr
, but we need to have single-quoted attribute value syntax for sanitized output. Accodring to whatwg spec, single quoted approach is also valid and supports values containing whitespaces.I've created a PR. Now it's available use new
quotedAttributeValueSyntax
config option. Default behaviour left intact so changes can be treated as enhancement.Let me know what you think