fix #245 #253
Merged
fix #245 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizongmin
reviewed
Apr 17, 2022
leizongmin
reviewed
Apr 17, 2022
leizongmin
reviewed
Apr 17, 2022
leizongmin
reviewed
Apr 17, 2022
leizongmin
reviewed
Apr 17, 2022
| throw new Error(); | ||
| } | ||
| } | ||
| ); | ||
| debug(html); | ||
| assert.equal( | ||
| html, | ||
| 'href="#" attr1="b" attr2="c" attr3 attr4="value4"e;" attr5' | ||
| 'href="#" attr1="b" attr2="c" attr3 attr4="value4"e;" attr5 attr6\\ attr7="123 456"' |
There was a problem hiding this comment.
这里结果不太符合预期，attr6\\ 应该为 attr6\\"
There was a problem hiding this comment.
这是因为正则var REGEXP_ILLEGAL_ATTR_NAME = /[^a-zA-Z0-9\\_:.-]/gim会对属性字符串过滤，双引号不在有效的属性符号内，所以被过滤掉了，这个PR理论上不涉及这个正则的逻辑更改
There was a problem hiding this comment.
如果你需要把双引号认为是合法的属性字符的话，我可以继续更改这个PR
lumburr
force-pushed
the
fix_attribute_name
branch
from
5f0eaf8 to
4ccbd0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #245
Case A
<span class=\"preference__text--green text--bold\">BP</span>classandtext--boldclassandtext--bold\Case B
<span class= "preference__text--green text--bold">BP</span>classandtext--boldclass