Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for allowList as an alias for whiteList #249

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

schu34
Copy link
Contributor

@schu34 schu34 commented Dec 13, 2021

addresses #219

@schu34 schu34 force-pushed the ms/add-allowlist-support branch from 0fe91d1 to 6914bba Compare December 13, 2021 18:30
@leizongmin leizongmin merged commit daa471e into leizongmin:master Dec 31, 2021
@schu34
Copy link
Contributor Author

schu34 commented Jan 2, 2022

@leizongmin Thanks for merging! Any idea when the next release will go out?

@yyandapalli
Copy link

@leizongmin
Hope you are doing well
Any idea when the next release will go out?

@leizongmin
Copy link
Owner

@schu34 @yyandapalli I have just publish a new version xss@1.0.11 that includes this change.

@yyandapalli
Copy link

Thank you very much, highly appreciate

@yyandapalli
Copy link

yyandapalli commented Mar 17, 2022

Hi @leizongmin,
My team is trying to use this new version of xss (1.0.11) and getting below error with this new version:

file.ts:27:25 - error TS2339: Property 'escapeAttrValue' does not exist on type '(html: string, options?: IFilterXSSOptions) => string'.

27 ? ${name}="${xss.escapeAttrValue(value)}"
~~~~~~~~~~~~~~~

file.ts:32:7 - error TS2339: Property 'filterXSS' does not exist on type '(html: string, options?: IFilterXSSOptions) => string'.

32 xss.filterXSS(dangerousHTML, makeXssOptions());


Any idea on why these errors are coming? Is it because of the changes done in xss.d.ts?
Any guidance is much appreciated

@yyandapalli
Copy link

Never mind, ignore this
We had to change the import as below to fix this:
import * as xss from "xss"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants