Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for src embedded image, ftp and relative urls #189

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

sijanec
Copy link
Contributor

@sijanec sijanec commented Feb 8, 2020

Those can't contain playloads. Reference to the issue #174

Those can't contain playloads. Reference to the issue leizongmin#174
@tamias
Copy link

tamias commented Feb 21, 2020

Note that I'm not a committer, but I notice two issues in your PR: Line 162 duplicates line 161, and line 166 should have substr(0, 3).

@sijanec
Copy link
Contributor Author

sijanec commented Feb 22, 2020

Thanks, @tamias , I added another commit with your information. I didn't really care about this pull, just wanted to inform the maintainers, I use a custom edited dist file in production.-

@leizongmin leizongmin merged commit 8e0b3c9 into leizongmin:master Jun 8, 2020
leizongmin added a commit that referenced this pull request Jun 8, 2020
leizongmin added a commit that referenced this pull request May 6, 2021
added support for src embedded image, ftp and relative urls
leizongmin added a commit that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants