Exit with status code 1 on error

[chrsm]

This addresses the issue my colleague reported here.

I think I caught all the appropriate cases (rather than just this specific one). Not sure if this is inline with how you'd prefer it to be implemented, happy to make adjustments.

[leighmcculloch]

Thanks for opening a fix for this and for addressing it for all the other error cases that weren't being captured in the exit status.

I'd be inclined to return the errors from the function, then capture the error in the main function, so that the main function is small and all other code is just passing errors.

What do you think?

[chrsm]

Hi @leighmcculloch no problem!

Since these changes are in main, are you suggesting some refactoring to move the indexing/writing into separate functions that just return errors? I can handle that.

[leighmcculloch]

Yup. The refactor is quite minor, just renaming main to something else like run that returns an error, and in main if error exit 1 as you did in the helper function.

[chrsm]

@leighmcculloch updated, let me know what you think! Sorry for the delay, I have been 😷

[leighmcculloch]

@chrsm Looks great!!! Thanks!!!