fix: allows spaces in bot project path (microsoft#4260)

lei9444 · Sep 24, 2020 · ad77082 · ad77082
1 parent 4137a2c
commit ad77082
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Composer/packages/client/src/recoilModel/dispatchers/storage.ts b/Composer/packages/client/src/recoilModel/dispatchers/storage.ts
@@ -76,7 +76,7 @@ export const storageDispatcher = () => {
     (callbackHelpers: CallbackInterface) => async (id: string, path: string) => {
       const { set } = callbackHelpers;
       try {
-        const response = await httpClient.get(`/storages/${id}/blobs`, { params: { path } });
+        const response = await httpClient.get(`/storages/${id}/blobs`, { params: { path: encodeURIComponent(path) } });
         const fetchedFocusStorage = response.data;
         fetchedFocusStorage.children = fetchedFocusStorage.children.reduce((files, file) => {
           if (file.type === FileTypes.FOLDER) {

diff --git a/Composer/packages/server/src/controllers/storage.ts b/Composer/packages/server/src/controllers/storage.ts
@@ -51,7 +51,7 @@ async function getBlob(req: Request, res: Response) {
     if (!req.query.path) {
       throw new Error('path missing from query');
     }
-    const reqpath = decodeURI(req.query.path);
+    const reqpath = decodeURIComponent(req.query.path);
     if (!Path.isAbsolute(reqpath)) {
       throw new Error('path must be absolute');
     }