Jacob Knowlton - Assignment 2 Optimization (llvm#58)

* Added working optimization * Finished tests * Added back whitespace before return * Wrapped optimization in scope block --------- Co-authored-by: Jacob Knowlton <u1117344@utah.edu>
leewei05 · Sep 10, 2024 · be4d746 · be4d746
1 parent 2817101
commit be4d746
Show file tree

Hide file tree

Showing 2 changed files with 89 additions and 0 deletions.
diff --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -5247,6 +5247,59 @@ Instruction* cs6475_optimizer(Instruction *I, InstCombinerImpl &IC, LazyValueInf
     }
   }
   // END JOHN REGEHR
+
+  // BEGIN JACOB KNOWLTON
+  {
+    Value *X1 = nullptr;
+    Value *X2 = nullptr;
+    // >= case
+    ICmpInst::Predicate Pred1 = ICmpInst::ICMP_SGE; 
+    if (match(I, m_ICmp(Pred1, m_Value(X), m_Value(Y)))) {
+      if (match(Y, m_ConstantInt(C))) {
+        if (C->isZero()) {
+          if (match(X, m_Mul(m_Value(X1), m_Value(X2)))) {
+            auto Mul1 = dyn_cast<BinaryOperator>(X);
+            if (Mul1->hasNoSignedWrap()) {
+              if (match(X1, m_Mul(m_Specific(X2), m_ConstantInt(C))) || match(X1, m_Shl(m_Specific(X2), m_ConstantInt(C)))) {
+                auto Mul2 = dyn_cast<BinaryOperator>(X1);
+                if (Mul2->hasNoSignedWrap()) {
+                  if (C->getUniqueInteger().isNonNegative()) {
+                    log_optzn("Jacob Knowlton");
+                    ICmpInst::Predicate Pred3 = ICmpInst::ICMP_EQ; 
+                    return new ICmpInst(Pred3, ConstantInt::getTrue(I->getContext()), ConstantInt::getTrue(I->getContext()));
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+    // > case
+    ICmpInst::Predicate Pred2 = ICmpInst::ICMP_SGT; 
+    if (match(I, m_ICmp(Pred2, m_Value(X), m_Value(Y)))) {
+      if (match(Y, m_ConstantInt(C))) {
+        if (C->isMinusOne()) {
+          if (match(X, m_Mul(m_Value(X1), m_Value(X2)))) {
+            auto Mul1 = dyn_cast<BinaryOperator>(X);
+            if (Mul1->hasNoSignedWrap()) {
+              if (match(X1, m_Mul(m_Specific(X2), m_ConstantInt(C))) || match(X1, m_Shl(m_Specific(X2), m_ConstantInt(C)))) {
+                auto Mul2 = dyn_cast<BinaryOperator>(X1);
+                if (Mul2->hasNoSignedWrap()) {
+                  if (C->getUniqueInteger().isNonNegative()) {
+                    log_optzn("Jacob Knowlton");
+                    ICmpInst::Predicate Pred3 = ICmpInst::ICMP_EQ; 
+                    return new ICmpInst(Pred3, ConstantInt::getTrue(I->getContext()), ConstantInt::getTrue(I->getContext()));
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+  }
+  // END JACOB KNOWLTON
 
   // BEGIN BRENSEN VILLEGAS
   {

diff --git a/llvm/test/Transforms/InstCombine/mul-const-icmp.ll b/llvm/test/Transforms/InstCombine/mul-const-icmp.ll
@@ -0,0 +1,36 @@
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+; Test 1: Simple Case (Optimization Applied)
+define i1 @test1(i16 %x) {
+  %mul1 = mul nsw i16 %x, 3 ; Positive constant
+  %mul2 = mul nsw i16 %mul1, %x
+  %cmp = icmp sge i16 %mul2, 0
+  ret i1 %cmp
+}
+
+; CHECK-LABEL: @test1(
+; CHECK-NEXT:    ret i1 true
+
+; Test 2: No `nsw` Flag (Optimization Not Applied)
+define i1 @test2(i16 %x) {
+  %mul1 = mul i16 %x, 3 ; No 'nsw' flag
+  %mul2 = mul i16 %mul1, %x
+  %cmp = icmp sge i16 %mul2, 0
+  ret i1 %cmp
+}
+
+; CHECK-LABEL: @test2(
+; CHECK-NOT:    ret i1 true 
+; CHECK: ret i1 %cmp
+
+; Test 3: Non-Positive Constant (Optimization Not Applied)
+define i1 @test3(i16 %x) {
+  %mul1 = mul nsw i16 %x, -5 ; Non-positive constant
+  %mul2 = mul nsw i16 %mul1, %x
+  %cmp = icmp sge i16 %mul2, 0
+  ret i1 %cmp
+}
+
+; CHECK-LABEL: @test3(
+; CHECK-NOT:    ret i1 true
+; CHECK: ret i1 %cmp