Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for chart.js v3 enable decimation #455

Closed
wants to merge 3 commits into from
Closed

Update for chart.js v3 enable decimation #455

wants to merge 3 commits into from

Conversation

kurkle
Copy link
Contributor

@kurkle kurkle commented Feb 12, 2021

No description provided.

@kurkle
Copy link
Contributor Author

kurkle commented Feb 12, 2021

late decimation (retained: 19.8 MB):
image

plugin decimation (retained: 10.1MB)
image

@leeoniya
Copy link
Owner

nice, big cpu improvement too (340ms -> 220ms scripting at least on linux for me, official tests run on windows).

noticed beta 10 has aliasing that causes blurry lines. is this expected? before/after:

chart-js

@kurkle
Copy link
Contributor Author

kurkle commented Feb 12, 2021

The decimation is done before layout, I think the blurry lines come from that. I think it can be improved.

@leeoniya
Copy link
Owner

i did a couple quick runs on Win10. there are some serious improvements:

scripting: 304ms -> 168ms
retained heap: 25MB -> 9.5MB

i'll merge this before next official bench run. feel free to force-push latest betas to this PR as they come out.

@benmccann
Copy link
Contributor

v3 final is out now so we can bump the version number, remove the Chart.js benchmark, and rename Chart.js-next to Chart.js. I was going to take a stab at that, but didn't want to conflict with this PR

@kurkle
Copy link
Contributor Author

kurkle commented Apr 3, 2021

Thanks for reminding @benmccann, I'll update this.

@kurkle kurkle changed the title Update for chart.js v3b10, enable decimation Update for chart.js v3 enable decimation Apr 3, 2021
@leeoniya
Copy link
Owner

leeoniya commented Apr 3, 2021

congrats on v3, exciting!

a forced Windows 20H2 update fucked up my windows install for unknown reasons, so i can only boot into my linux partition for now. it's looking like i' need to do a full wipe, but it's also my work laptop so i've been hesitent to sink a bunch of time into reinstalling all the things :(

i'll either need to bite that bullet or do the next bench batch on my [faster] desktop. i typically like to do bench runs on less powerful devices, since it tends to reveal a lot more than running it all on a supercomputer. :)

@leeoniya leeoniya closed this in 32890c7 Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants