Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally display remaining time #592

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

vmobilis
Copy link
Contributor

@vmobilis vmobilis commented Feb 9, 2025

  1. Move pretty_progress() calls from sample() to sample_k_diffusion() to account all time taken by sampling cycle.
  2. Add pretty_progress() with time remainder.
  3. Add configuration option to use that additional function.

Disadvantage: @yslai already implemented DDIM and TCD samplers (#568), and after this change he will need to append show_step(i, steps, &t0); line to end of their cycles.

And thanks for the program!

@vmobilis vmobilis changed the title Move pretty_progress() calls from sample() to sample_k_diffusion() Display remaining time Feb 12, 2025
@vmobilis vmobilis changed the title Display remaining time Optionally display remaining time Feb 12, 2025
A floor() is needed.
Also, clean the time after finish of sampling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant