Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap IIFE for hermes optimization #7

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

leegeunhyeok
Copy link
Owner

@leegeunhyeok leegeunhyeok commented Sep 19, 2023

Description

Fix performance issue on hermes runtime

  • in local scope(IIFE), poor performance on hermes runtime.
  • remove IIFE for modules initialize on global scope.
    • change esbuild bundle format 'iife' to 'esm' for remove IIFE.

close #5

- in local scope(iife), poor performance on hermes runtime
- remove iife for modules initialize on global scope
  - change esbuild bundle format iife to esm for remove iife

close #5
@leegeunhyeok leegeunhyeok self-assigned this Sep 19, 2023
@leegeunhyeok leegeunhyeok merged commit 220233f into master Sep 19, 2023
@leegeunhyeok leegeunhyeok deleted the fix/5-hermes-initialize-performance branch September 19, 2023 20:16
@leegeunhyeok leegeunhyeok changed the title Unwrap iife for hermes optimization Unwrap IIFE for hermes optimization Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow on startup when enable Hermes
1 participant