Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling case sensitivity doesn't update the search results #29

Closed
leecbaker opened this issue Jun 4, 2018 · 1 comment
Closed

Toggling case sensitivity doesn't update the search results #29

leecbaker opened this issue Jun 4, 2018 · 1 comment
Assignees
@leecbaker
Labels
bug confirmed

Comments

@leecbaker
Copy link
Owner

Like it says in the title.
@leecbaker leecbaker self-assigned this Jun 4, 2018
@leecbaker
Copy link
Owner Author

After more investigation, this only happens when regex is selected, and case sensitivity is toggled.

If case sensitivity is toggled, and regex is already turned on, the regular expression isn't re-compiled- so we keep using the old regular expression, with the old case sensitivity setting.

leecbaker added a commit that referenced this issue Dec 3, 2019
@leecbaker
When toggling case sensitivity, rebuild the search regex if necessary.
2eacec6 
Fixes #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leecbaker leecbaker

Labels
bug confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leecbaker