Add features to facilitate multi-currency alignment #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alerque
force-pushed
the
multicurrency-alignment
branch
from
f045b55 to
5dbe724
Compare
alerque
force-pushed
the
multicurrency-alignment
branch
from
5dbe724 to
6c6501c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79. The feature supplied is subtly different than the one requested since we don't really differentiate the different parts of a posting (unit, cost, total, etc.) but the most common cases are going to be either the first or last instance of thousand separators so this should provide more most use cases. Not covered would be multi-currency with conflicting thousands place and decimal separators where alignment of the first decimal separator is desired. If anybody wants that mode I would be willing to facilitate a PR, but I don't need it myself and so didn't put out the effort to cover it here.
Closes #106. That issue was mostly solved already by #107 and could probably have been closed. This does not directly address alignment on commodity, but it does provide another alternative that would make it possible to align even multiple commodities given that you could specify your commodity symbol(s) as decimal separators.