Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support testnet 4 #5910

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: support testnet 4 #5910

merged 1 commit into from
Oct 21, 2024
+1,342 −1,621

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Oct 17, 2024 •
edited by leather-bot
Loading

Try out Leather build 1b455a5 — Extension build, Test report, Storybook, Chromatic

Closes LEA-1406

Adds testnet4 option

@linear Linear
Copy link

linear bot commented Oct 17, 2024

LEA-1406 Support for testnet4 on extension

@kyranjamie kyranjamie force-pushed the feat/testnet4 branch 2 times, most recently from 46876cd to 17a0977 Compare October 17, 2024 12:23
@kyranjamie kyranjamie force-pushed the feat/testnet4 branch 2 times, most recently from eb135a1 to 780177f Compare October 17, 2024 13:43
@kyranjamie kyranjamie force-pushed the feat/testnet4 branch 2 times, most recently from 3c6c26e to fe12ec9 Compare October 18, 2024 09:12
alter-eggo
alter-eggo reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@alter-eggo alter-eggo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json deleted

src/app/features/add-network/network-form-fields.tsx Outdated Show resolved Hide resolved
@kyranjamie kyranjamie force-pushed the feat/testnet4 branch 2 times, most recently from 0ba863c to 28539a5 Compare October 18, 2024 11:50
pete-watters
pete-watters approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

I added some suggestions about keeping the URL code DRY but it's not a big deal as the code is already like that anyway

@kyranjamie kyranjamie added this pull request to the merge queue Oct 21, 2024
Merged via the queue into dev with commit 399b185 Oct 21, 2024
30 checks passed
@kyranjamie kyranjamie deleted the feat/testnet4 branch October 21, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alter-eggo alter-eggo alter-eggo left review comments

@pete-watters pete-watters pete-watters approved these changes

@fbwoolf fbwoolf fbwoolf approved these changes

@alexp3y alexp3y Awaiting requested review from alexp3y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyranjamie @pete-watters @fbwoolf @alter-eggo