feat: support multiple recipients in rpc send transfer method, closes #5174

[alter-eggo]

Try out Leather build 6fd3bc3 — Extension build, Test report, Storybook, Chromatic

This pr supports multiple recipients in rpc send transfer method

[kyranjamie]

Imperative coding style. How can we do without reassigning var?

[alter-eggo]

refactored a bit
but left variable, we need to assign somewhere converted params 🤔

[markmhendrickson]

@alter-eggo is there a way to test this in the test app or elsewhere?

[alter-eggo]

@markmhendrickson yes, I've added btn to test app

[kyranjamie]

[alter-eggo]

@kyranjamie fixed, problem is on current dev as well

[markmhendrickson]

@alter-eggo For updating the docs: It seems the developer can continue passing a string address value as recipient or an array of string values as recipients, correct?

[alter-eggo]

@markmhendrickson yes, it's backwards compatible

[markmhendrickson]

I'm seeing now that previously / currently we have amount as the parameter. So by backwards compatible, you mean both amount and recipient are still supported, correct? Do we have tests that enforce this?

[alter-eggo]

by backwards compatible I mean even if you pass address and amount - it will work. there are tests, but it can be tested as well in test app.
this fn converts legacy params to new ones:

export function convertRpcSendTransferLegacyParamsToNew(params: RpcSendTransferParamsLegacy) {
  return {
    recipients: [{ address: params.address, amount: params.amount }],
    network: params.network,
    account: params.account,
  };
}