Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add wallet user survey, adjust styling #5158

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

fabric-8
Copy link
Contributor

@fabric-8 fabric-8 commented Apr 3, 2024

Try out Leather build f389eccExtension build, Test report, Storybook, Chromatic

Adds user survey while tweaking alignments / styling of in-app-message-item.tsx

Would be great if we could hide this during onboarding as we don't want to target users who are just installing / onboarding, but depends on the est. effort

The component generally looks a bit dated and due to be refactored, however that's a bit beyond my horizon. So I focussed to make things look right without performing major refactors.

CleanShot 2024-04-03 at 00 56 10@2x CleanShot 2024-04-03 at 00 56 29@2x

Copy link
Contributor

@fbwoolf fbwoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 3, 2024

Once this is merged, and you rebase on it, the test here will pass: #5157

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to see a non-dev modify the config ✨

Unless changed, this used to only show on home screen anyway, so think we're good.

Happy to make changes to this to improve it, make it more useful. It should be versatile enough to cover all simple banner use cases, without publishing changes.

@fabric-8
Copy link
Contributor Author

fabric-8 commented Apr 3, 2024

@kyranjamie When testing this locally it was showing up during onboarding as well — Is the behaviour expected to be different once in actual prod environment?

@kyranjamie
Copy link
Collaborator

@kyranjamie When testing this locally it was showing up during onboarding as well — Is the behaviour expected to be different once in actual prod environment?

No, that sounds like a regression

@fabric-8
Copy link
Contributor Author

fabric-8 commented Apr 3, 2024

@kyranjamie Thank you 🚀❤️

@fabric-8 fabric-8 added this pull request to the merge queue Apr 3, 2024
Merged via the queue into dev with commit 8228c11 Apr 3, 2024
27 checks passed
@fabric-8 fabric-8 deleted the chore/user-survey-message branch April 3, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants