-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add wallet user survey, adjust styling #5158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Once this is merged, and you rebase on it, the test here will pass: #5157 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy to see a non-dev modify the config ✨
Unless changed, this used to only show on home screen anyway, so think we're good.
Happy to make changes to this to improve it, make it more useful. It should be versatile enough to cover all simple banner use cases, without publishing changes.
@kyranjamie When testing this locally it was showing up during onboarding as well — Is the behaviour expected to be different once in actual prod environment? |
No, that sounds like a regression |
c47802e
to
f389ecc
Compare
@kyranjamie Thank you 🚀❤️ |
Adds user survey while tweaking alignments / styling of
in-app-message-item.tsx
Would be great if we could hide this during onboarding as we don't want to target users who are just installing / onboarding, but depends on the est. effort
The component generally looks a bit dated and due to be refactored, however that's a bit beyond my horizon. So I focussed to make things look right without performing major refactors.