Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: client side nested button error #5117

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: client side nested button error #5117

merged 1 commit into from
Mar 25, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Mar 24, 2024 •
edited by leather-bot
Loading

Try out Leather build 3ec6c78 — Extension build, Test report, Storybook, Chromatic

Added a conditional wrapper to CryptoCurrencyAssetItemLayout.

Avoids runtime err stating button can be used within a button. On homepage, it isn't interactive so shouldn't be in a Pressable.

@kyranjamie kyranjamie requested a review from fbwoolf March 24, 2024 17:27
fbwoolf
fbwoolf approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@fbwoolf fbwoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for fix. 👍

@kyranjamie kyranjamie added this pull request to the merge queue Mar 25, 2024
Merged via the queue into dev with commit c800721 Mar 25, 2024
31 checks passed
@kyranjamie kyranjamie deleted the chore/nested-button-err branch March 25, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyranjamie @fbwoolf