Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shimmer animation to account bns name and total balance #5112

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Mar 21, 2024

Try out Leather build 59d44e9Extension build, Test report, Storybook, Chromatic

This pr adds shimmer animation to account bns name and total balance in switch account modal

Screen.Recording.2024-03-21.at.13.50.23.mov
Screen.Recording.2024-03-21.at.16.06.21.mov

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

If there's no cached balance though, shouldn't we shimmer something other than $0.00? Something to effect of $—.-?

@alter-eggo alter-eggo merged commit d9c1490 into feat/debounced-query Mar 21, 2024
21 of 22 checks passed
@alter-eggo alter-eggo deleted the feat/shimmer-switch-account branch March 21, 2024 16:07
@fbwoolf
Copy link
Contributor

fbwoolf commented Mar 21, 2024

cc @fabric-8 @markmhendrickson so you are aware of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants