Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support gltf inscription type, closes #5091 #5099

Merged
merged 1 commit into from
Mar 19, 2024
Merged

feat: support gltf inscription type, closes #5091 #5099

merged 1 commit into from
Mar 19, 2024

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Mar 19, 2024 •
edited by github-actions bot
Loading

Try out this version of Leather — Extension build, Test report, Storybook preview

This pr adds support for gltf inscription type, preview is opened in ordinals.com iframe

@alter-eggo alter-eggo linked an issue Mar 19, 2024 that may be closed by this pull request
Display collectible previews for inscriptions with "model/gltf+json" mimetype #5091
Closed
kyranjamie
kyranjamie approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any easy way we can track analytics events to see if there are unsupported mime types?

@alter-eggo
Copy link
Contributor Author

alter-eggo commented Mar 19, 2024 •
edited
Loading

@kyranjamie
if (branches.other) return branches.other(); in src/shared/models/inscription.model.ts
put analytics event here?

upd. added this

@alter-eggo alter-eggo added this pull request to the merge queue Mar 19, 2024
Merged via the queue into dev with commit a303de4 Mar 19, 2024
28 checks passed
@alter-eggo alter-eggo deleted the feat/support-gltf branch March 19, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display collectible previews for inscriptions with "model/gltf+json" mimetype
2 participants
@alter-eggo @kyranjamie