fix: gaia profile test #5073
Merged
fix: gaia profile test #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
fix/gaia-profile-test
branch
2 times, most recently
from
beb5687
to
a29b2e6
Compare
Closed
pete-watters
approved these changes
Mar 14, 2024
| await testAppPage.clickUpdateProfileButton(); | ||
| const profileUpdatingPage = new UpdateProfileRequestPage(await context.waitForEvent('page')); | ||
|
|
||
| const requestPromise = profileUpdatingPage.page.waitForRequest('https://hub.blockstack.org/*'); | ||
|
|
||
| await profileUpdatingPage.page.route('https://gaia.hiro.so/hub/*', async route => { |
There was a problem hiding this comment.
Maybe we can use this approach to add some mocks for Ordinals so we can test the send BRC20 / ordinal flow?
I need to do that soon as it suprised me again on containers. I have this task for a while
kyranjamie
approved these changes
Mar 14, 2024
tests/specs/profile/profile.spec.ts
Outdated
| @@ -13,14 +12,19 @@ test.describe('Profile updating', () => { | |||
| await onboardingPage.signInWithTestAccount(extensionId); | |||
| testAppPage = await TestAppPage.openDemoPage(context); | |||
| await testAppPage.signIn(); | |||
| }); | |||
|
|
|||
| test.describe.configure({ mode: 'serial' }); | |||
There was a problem hiding this comment.
With the mocking is serial necessary?
There was a problem hiding this comment.
I can try removing it.
|
|
||
| test.skip('should send a signed profile token to gaia', async ({ context }) => { | ||
| await testAppPage.clickUpdateProfileButton(); | ||
| const profileUpdatingPage = new UpdateProfileRequestPage(await context.waitForEvent('page')); | ||
|
|
||
| const requestPromise = profileUpdatingPage.page.waitForRequest('https://hub.blockstack.org/*'); |
There was a problem hiding this comment.
Does this trigger at all? I half-looked into this and couldn't get this to log
There was a problem hiding this comment.
I did see the log when using --ui flag running tests in UI mode.
fbwoolf
force-pushed
the
fix/gaia-profile-test
branch
2 times, most recently
from
1c01286
to
24fdbdb
Compare
fbwoolf
force-pushed
the
fix/gaia-profile-test
branch
from
24fdbdb
to
dbfac38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching the route to gaia and mocking the profile response in hopes of fixing the profile test. 🤞