Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ledger no request keys context #4888

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

edgarkhanzadian
Copy link
Contributor

@edgarkhanzadian edgarkhanzadian commented Feb 1, 2024

Try out this version of Leather — Extension build, Test report

Here's some testing of different scenarios:

ledgerTesting720.mov

Note: will squash commits together after approval

@edgarkhanzadian
Copy link
Contributor Author

@314159265359879 , please, let me know if there are any other scenarios worth testing on this branch.

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice refactor. Been wanting to get this done for ages!

@314159265359879
Copy link
Contributor

@314159265359879 , please, let me know if there are any other scenarios worth testing on this branch.

I believe you covered them, very nice!

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @edgarkhanzadian

Please rebase the merges before merging

@edgarkhanzadian edgarkhanzadian force-pushed the fix/ledger-no-request-keys-context branch from ffe6690 to 5242a52 Compare February 6, 2024 09:35
@edgarkhanzadian edgarkhanzadian added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@edgarkhanzadian edgarkhanzadian added this pull request to the merge queue Feb 6, 2024
Merged via the queue into dev with commit d57f005 Feb 6, 2024
28 checks passed
@edgarkhanzadian edgarkhanzadian deleted the fix/ledger-no-request-keys-context branch February 6, 2024 10:05
Copy link

sentry-io bot commented Feb 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: DisconnectedDeviceDuringOperation: Failed to execute 'transferOut' on 'USBDevice': The device was... getStacksAppVersion(/./src/app/features/ledger/... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants