Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the wallet is locked users want to see the top right menu to sign out #5777

Closed
314159265359879 opened this issue Aug 16, 2024 · 3 comments · Fixed by #5785
Closed

When the wallet is locked users want to see the top right menu to sign out #5777

314159265359879 opened this issue Aug 16, 2024 · 3 comments · Fixed by #5785
Assignees
@pete-watters
Labels
bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds

Comments

@314159265359879
Copy link
Contributor

image

This is a bug, we used to have the menu and options available even when the wallet was locked.

If someone wants to reset their password, they have to reinstall the extension to work around this issue.
@314159265359879 314159265359879 added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds labels Aug 16, 2024
@pete-watters pete-watters self-assigned this Aug 16, 2024
@pete-watters
Copy link
Contributor

Thanks @314159265359879 , I'll get this fixed quickly

pete-watters added a commit that referenced this issue Aug 19, 2024
@pete-watters
fix: add default true to show settings to make sure it shows for lock…
5b86572 
…ed screens, closes #5777
@pete-watters pete-watters mentioned this issue Aug 19, 2024
Merged
@pete-watters pete-watters linked a pull request Aug 19, 2024 that will close this issue
Show settings menu when session locked #5785
Merged
pete-watters added a commit that referenced this issue Aug 19, 2024
@pete-watters
fix: add default true to show settings to make sure it shows for lock…
e5bcfd1 
…ed screens, closes #5777
pete-watters added a commit that referenced this issue Aug 21, 2024
@pete-watters
fix: add default true to show settings to make sure it shows for lock…
63dffd4 
…ed screens, closes #5777
pete-watters added a commit that referenced this issue Aug 21, 2024
@pete-watters
fix: add default true to show settings to make sure it shows for lock…
fcf0e0a 
…ed screens, closes #5777
github-merge-queue bot pushed a commit that referenced this issue Aug 21, 2024
@pete-watters
fix: add default true to show settings to make sure it shows for lock…
96b2990 
…ed screens, closes #5777
@pete-watters pete-watters mentioned this issue Aug 21, 2024
Merged
@markmhendrickson
Copy link
Collaborator

Let's get a (screenshot-based) integration test in place?

@pete-watters
Copy link
Contributor

Let's get a (screenshot-based) integration test in place?

To get screenshot based testing in place I will need to do some investigations in here first.

For this issue, I will be able to capture it with a standard test which I should have done initially. I will schedule some time this week to add better coverage for these latest introduced regressions

@pete-watters pete-watters reopened this Aug 22, 2024
kyranjamie pushed a commit that referenced this issue Aug 26, 2024
@semantic-release-bot
chore(release): 6.46.0
5c6f821 
## [6.46.0](v6.45.2...v6.46.0) (2024-08-26)

### Features

* change balance load logic, closes leather-io/issues[#227](#227) ([faf71fb](faf71fb))

### Bug Fixes

* add default true to show settings to make sure it shows for locked screens, closes [#5777](#5777) ([96b2990](96b2990))
* do not capitalise add network ([5258d7e](5258d7e))
* empty space in settings dropdown ([d33df6f](d33df6f))
* failing ledger test ([67799fe](67799fe))
* fix formatting of add network ui, closes leather-io/issues[#5735](#5735) ([8a76b5f](8a76b5f))
* fix issues with alignment of page headers ([ea76352](ea76352))
* **ledger:** support stx_signMessage, closes [#5756](#5756) ([92a99ed](92a99ed))
* make headers more composable, prevent logo hover, closes leather-io/issues[#4597](#4597) ([3f2e359](3f2e359))
* minimum bitcoin spend, closes [#5739](#5739) ([34405f6](34405f6))
* prevent illegal constructor error ([a774b66](a774b66))
* remove blockstream from tests and add network form ([86af370](86af370))
* remove card from retrieve taproot ui ([27ca424](27ca424))
* **sentry:** sample performance units, closes leather-io/issues[#249](#249) ([3b6a5d8](3b6a5d8))
* tool to clear submitted tx state ([1e6f63d](1e6f63d))
* update ui library and deprecate footer ([0f5cfa2](0f5cfa2))
* validate dom nesting console error ([fe21fa8](fe21fa8))

### Internal

* differentiate action popup and popup, improve responsiveness and refactor footers, ref [#5260](#5260) ([2cae2a2](2cae2a2))
* hide lock option if wallet already locked ([b43cf8b](b43cf8b))
* post-release merge back ([686a823](686a823))
* remove back button on unlock screen and remove fragment ([9bc13ab](9bc13ab))
* update monorepo dependancies ([427f82f](427f82f))
* update prettier ([9e7d404](9e7d404))
* update tanstack libraries ([1486f5c](1486f5c))
@camerow camerow closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show settings menu when session locked leather-io/extension
4 participants
@markmhendrickson @pete-watters @camerow @314159265359879