Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent submission when selecting info icon in send flow for available balance #5258

Closed
markmhendrickson opened this issue Apr 18, 2024 · 1 comment · Fixed by #5272
Closed

Prevent submission when selecting info icon in send flow for available balance #5258

markmhendrickson opened this issue Apr 18, 2024 · 1 comment · Fixed by #5272
Assignees
@pete-watters
Labels
area:send bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds
Milestone
Redesign send UX

Comments

@markmhendrickson
Copy link
Collaborator

I'm not sure why it currently submits the form but it does:

Screen.Recording.2024-04-15.at.09.57.35.mov
@markmhendrickson markmhendrickson added bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds area:send labels Apr 18, 2024
@markmhendrickson markmhendrickson added this to the Redesign send UX milestone Apr 18, 2024
pete-watters added a commit that referenced this issue Apr 19, 2024
@pete-watters
fix: prevent form submit on tooltip click, ref #5258
8764f49
pete-watters added a commit that referenced this issue Apr 19, 2024
@pete-watters
fix: prevent form submit on tooltip click, ref #5258
64bb8c2
@pete-watters pete-watters linked a pull request Apr 19, 2024 that will close this issue
fix: prevent form submit on tooltip click, ref #5258 #5272
Merged
@pete-watters pete-watters self-assigned this Apr 19, 2024
@pete-watters
Copy link
Contributor

This is to do with clicking the tooltip triggering form validation. I added a fix for it just now

pete-watters added a commit that referenced this issue Apr 19, 2024
@pete-watters
fix: prevent form submit on tooltip click, ref #5258
2013e29
github-merge-queue bot pushed a commit that referenced this issue Apr 22, 2024
@pete-watters
fix: prevent form submit on tooltip click, ref #5258
8735380
@alter-eggo alter-eggo mentioned this issue Apr 23, 2024
Merged
kyranjamie pushed a commit that referenced this issue Apr 24, 2024
@semantic-release-bot
chore(release): 6.36.0
b2922eb 
## [6.36.0](v6.35.1...v6.36.0) (2024-04-24)

### Features

* brc-20 token balances as fiat, [#4408](#4408) ([0942131](0942131))
* decrease num of addresses to fetch ([b0276ec](b0276ec))
* increase hiro rate limiter ([51cf2c0](51cf2c0))

### Bug Fixes

* allow virtuoso to resize dynamically, ref [#5242](#5242) ([5d618aa](5d618aa))
* prevent form submit on tooltip click, ref [#5258](#5258) ([8735380](8735380))
* problem with endless loading of balances and names ([15202f4](15202f4))
* rpc send transfer params network validation, closes [#5284](#5284) ([a6f774c](a6f774c))
* rpc send transfer recipient default network ([4410185](4410185))
* show hash formatting, ref [#5261](#5261) ([5264a99](5264a99))

### Internal

* post-release merge back ([6a53bff](6a53bff))
* price as market data ([773421b](773421b))
* remove unneeded logger errors ([b4d73f8](b4d73f8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:send bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds
Projects
None yet
Milestone
Redesign send UX
Development

Successfully merging a pull request may close this issue.

fix: prevent form submit on tooltip click, ref #5258 leather-io/extension
2 participants
@markmhendrickson @pete-watters