Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete icon alignment for network #5124

Closed
markmhendrickson opened this issue Mar 26, 2024 · 3 comments · Fixed by #5726
Closed

Fix delete icon alignment for network #5124

markmhendrickson opened this issue Mar 26, 2024 · 3 comments · Fixed by #5726
Assignees
@alter-eggo
Labels
area:networks bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds effort:small Expected to take up to 1 day of integration work needs:visual-improvement
Milestone
Fix urgent bugs

Comments

@markmhendrickson
Copy link
Collaborator

Screenshot 2024-03-26 at 11 39 04
@markmhendrickson
Copy link
Collaborator Author

@fabric-8 do we have guidance on the 🗑️ icon placement in Figma to link here?

@fabric-8
Copy link
Contributor

fabric-8 commented Mar 26, 2024 •
edited
Loading

Just added some guidance here. I assume we'd also want to let people edit networks they've added?

CleanShot 2024-03-26 at 18 11 58@2x

@pete-watters pete-watters added the effort:small Expected to take up to 1 day of integration work label Apr 19, 2024
@pete-watters pete-watters added this to the Fix urgent bugs milestone Apr 19, 2024
@markmhendrickson markmhendrickson added bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds labels May 20, 2024
@pete-watters
Copy link
Contributor

Another task to complete as part of this is to truncate the network name in the dropdown menu if its too long:
#2248

It's not breaking the UI now but could do with some ellipsis
Screenshot 2024-06-28 at 11 26 45

@pete-watters pete-watters self-assigned this Jun 28, 2024
@pete-watters pete-watters mentioned this issue Jun 28, 2024
Closed
alter-eggo added a commit that referenced this issue Jul 26, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
92d4af6
alter-eggo added a commit that referenced this issue Jul 26, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
41b4f5c
alter-eggo added a commit that referenced this issue Jul 31, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
cc67f22
alter-eggo added a commit that referenced this issue Jul 31, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
744505a
alter-eggo added a commit that referenced this issue Jul 31, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
1602f5e
alter-eggo added a commit that referenced this issue Jul 31, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
18d46e7
alter-eggo added a commit that referenced this issue Aug 1, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
2339b0d
alter-eggo added a commit that referenced this issue Aug 2, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
fef34d8
alter-eggo added a commit that referenced this issue Aug 5, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
640b1c6
github-merge-queue bot pushed a commit that referenced this issue Aug 5, 2024
@alter-eggo
feat: add handle network item menu, closes #5124
7a778a1
@alter-eggo alter-eggo mentioned this issue Aug 6, 2024
Merged
@markmhendrickson markmhendrickson linked a pull request Aug 7, 2024 that will close this issue
release: nostalgic skunk #5726
Merged
kyranjamie pushed a commit that referenced this issue Aug 8, 2024
@semantic-release-bot
chore(release): 6.45.0
499bc64 
## [6.45.0](v6.44.2...v6.45.0) (2024-08-08)

### Features

* add handle network item menu, closes [#5124](#5124) ([7a778a1](7a778a1))
* **analytics:** background analytics event ([967f7b1](967f7b1))
* implement mempool api, closes leather-io/issues[#215](#215) ([0608cb8](0608cb8))

### Bug Fixes

* account change in open frames ([ac21ff8](ac21ff8))
* default to first account as useCurrentStacksAccount returns undefined, ref [#5683](#5683) ([d67d238](d67d238))
* disable stx transfer if form is not valid ([8c9dc16](8c9dc16))
* empty logo in popup mode ([10af7db](10af7db))
* fix visual bug on hover of PSBT copy, ref [#4972](#4972) ([64d2fb6](64d2fb6))
* logo box show ([0cf3dae](0cf3dae))
* mainnet faker contract address ([17d71a8](17d71a8))
* remove sign out if there are no keys ([051b1b5](051b1b5))

### Internal

* force resolution of fast-xml-parser ([bbded02](bbded02))
* import DialogHeader from monorepo ([1878330](1878330))
* post-release merge back ([8a77da4](8a77da4))
* readd fragments to help escape single quote ([8ac4349](8ac4349))
* refactor containers to make them more composable, ref [#4370](#4370) ([231842f](231842f))
* refactor switch-account to use shared context ([10254d9](10254d9))
* refactor TwoColumn to remove unneeded fragments ([b5b7988](b5b7988))
* update org name ([da5cc05](da5cc05))
* update react-virtuoso package ([c874c00](c874c00))
* update ui and query packages ([5e2547c](5e2547c))
@314159265359879 314159265359879 mentioned this issue Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alter-eggo alter-eggo

Labels
area:networks bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds effort:small Expected to take up to 1 day of integration work needs:visual-improvement
Projects
None yet
Milestone
Fix urgent bugs
Development

Successfully merging a pull request may close this issue.

release: nostalgic skunk leather-io/extension
4 participants
@markmhendrickson @pete-watters @fabric-8 @alter-eggo