Store swap asset info in routing

[kyranjamie]

Suggest we use a scheme of lowercase urls

/swap
/swap/base
/swap/base/quote

[fbwoolf]

Skipping this issues while #4425 is in flight so I don't mess up route changes.

[markmhendrickson]

I'm not entirely clear what states these paths are meant to represent?

E.g. when I use the token picker in the current swaps flow, I see /swaps/choose-asset

[fbwoolf]

@kyranjamie is this issue still needed? Can you clarify why this is necessary? I can't say I totally understand what I'd be implementing here? So, as the user selects each token the route changes?

[kyranjamie]

Can you clarify why this is necessary?

It's not absolutely necessary, but it's good application design. A core principal of the web is that locations have unique identifiers in the form of a URL. When building features, and even designing them, it's helpful to consider how they map to URLs, as this is easier than trying to retrofit functionality later.

I can't say I totally understand what I'd be implementing here?

I'd suggest the implementation saves the state of which tokens are selected in the URL, rather than custom component/context state. useParams to get the state from router.

So, as the user selects each token the route changes?

Yeah, that's how all exchanges work. The URL changes when you go to another trading pair. Examples 👇🏼

Coinbase

Binance

Kraken

Benefits of building features with descriptive URLs:

• User can link directly to a trading pair
• User can bookmark trading pair
• Power user can directly modify the URL to get where they want (I do this on exchanges all the time)
• Developer can navigate directly to a specific trading pair
  • If we needed that feature, how would we build it now?
• Analytics are included out-the-box

[markmhendrickson]

I presume that this improved routing will also help with SEO once we move swaps to the web app.

[fbwoolf]

Yeah, that's how all exchanges work. The URL changes when you go to another trading pair. Examples 👇🏼

Coinbase
Binance
Kraken
Benefits of building features with descriptive URLs:

These are just centralized exchange pairs, I was looking for a defi swapping UI example. ALEX doesn't do it, but I do see that Jupiter does. 👍

[fbwoolf]

Just checked Uniswap does not. 🤔

[fbwoolf]

Interesting, but if I type in the pair, Jupiter does not recognize it...

EDIT: Must be a bug with WIF, haha, bc worked with USDC...

[fbwoolf]

Kinda nuts Uniswap doesn't...

[kyranjamie]

Don't see relevance of centralised or decentralised. Swaps and trades are effectively the same action to a user. There's an exchange of one asset for another, and the interfaces are identical. Unisat is not an example we want to follow 😅

This isn't a discussion specific to swaps, though. It's a question of: Does it make senes for this information to go in the URL?

Examples asides, I'm curious to hear your take @fbwoolf. What is the argument against doing this?

[fbwoolf]

Examples asides, I'm curious to hear your take @fbwoolf. What is the argument against doing this?

I think you are mistaking my curiosity with 'arguing' against something. I think you are misreading my comments here. I don't have an argument against it. I def think it is better. I was just looking to play around with the experience of a swapping UI where the user (me) was seeing the route change based on the tokens I was selecting (or typing into the url). I just hadn't come across it before, or used. My comment on the centralized exchange was that the pairs are set up to choose from typically where I don't see that with decentralized exchanges ...but I might just be missing something there.

[kyranjamie]

All good. Sorry, I did indeed read your comments in a way thinking you were counter arguing—which is totally fine if you disagree. Gloves off 🥊

[fbwoolf]

I started on this work yest, but realized it is going to conflict quite a bit with changes in the container work with the BaseDrawer being removed and routing changes. I will keep this inflight, but I'm going to stall and start another issue today.