Glitch: Welcome screen flashes before showing analytics consent page #2330
Assignees
Labels
Comments
github-project-automation
bot
moved this to Enhancements backlog
in Hiro Wallet (DEPRECATED)
markmhendrickson
moved this from Enhancements backlog
to Prioritized
in Hiro Wallet (DEPRECATED)
pete-watters
added
the
effort:medium
|
I think this may have been fixed already as part of this refactor: |
|
Maybe yeah, though just checked and in bg script, on install, we navigate to onboarding page first rather than the diagnostics page. Think this can change |
pete-watters
added a commit
that referenced
this issue
Jun 30, 2023
pete-watters
added a commit
that referenced
this issue
Jun 30, 2023
Merged
blockstack-devops
pushed a commit
that referenced
this issue
Jul 18, 2023
## [4.36.0](v4.35.0...v4.36.0) (2023-07-18) ### Features * change arrow icon in send flow ([2b4a2a9](2b4a2a9)) * change caret color in seed phrase input ([8fc248c](8fc248c)) ### Bug Fixes * add module type ([227ea75](227ea75)) * choose acc total balance, closes [#3989](#3989) ([6e4bedf](6e4bedf)) * disable sentry in service worker ([d5e8f26](d5e8f26)) * entire activity item is clickable ([167429b](167429b)) * exceed amount in rbf, closes [#3921](#3921) ([0d8e72f](0d8e72f)) * form restore ([c48fc22](c48fc22)) * go to RequestDiagnostics after fresh installation to avoid flash redirect, fixes [#2330](#2330) ([bef7e08](bef7e08)) * port disconnecting ([da3a2f5](da3a2f5)) * prevent secret key showing before blurred ([6929ada](6929ada)) * refactor JSX namespace to React.JSX ([4a07bcb](4a07bcb)) * retore form state, chromium ([be3204d](be3204d)) * secret key input, closes [#3954](#3954) ([5f000ba](5f000ba)) * stacks nfts loading key not unique, closes [#3789](#3789) ([dad5d6e](dad5d6e)) * upgrade packages ([74f6d25](74f6d25)) * use routes over state for home tabs, closes [#3518](#3518) ([cb2f317](cb2f317)) * use windows friendly syntax so that yarn dev will launch on windows machines ([56b6778](56b6778)) ### Internal * keychain ([c5d4761](c5d4761)) * migrate to manifest version 3 ([03dbb1e](03dbb1e)) * mv3 fix ([0f54a1f](0f54a1f)) * restore gaia functionality ([bf136dc](bf136dc)) * sending max fees, closes [#3871](#3871) ([90c1c31](90c1c31)) * stacks keychain logic ([846132b](846132b)) * upgrade packages ([d3978f0](d3978f0)) * upgrade packages, p1 ([cb7da02](cb7da02)) * upgrade packages, p2 ([51b7da0](51b7da0))
kyranjamie
pushed a commit
that referenced
this issue
Jul 18, 2023
## [4.36.0](v4.35.0...v4.36.0) (2023-07-18) ### Features * change arrow icon in send flow ([2b4a2a9](2b4a2a9)) * change caret color in seed phrase input ([8fc248c](8fc248c)) ### Bug Fixes * add module type ([227ea75](227ea75)) * choose acc total balance, closes [#3989](#3989) ([6e4bedf](6e4bedf)) * disable sentry in service worker ([d5e8f26](d5e8f26)) * entire activity item is clickable ([167429b](167429b)) * exceed amount in rbf, closes [#3921](#3921) ([0d8e72f](0d8e72f)) * form restore ([c48fc22](c48fc22)) * go to RequestDiagnostics after fresh installation to avoid flash redirect, fixes [#2330](#2330) ([bef7e08](bef7e08)) * port disconnecting ([da3a2f5](da3a2f5)) * prevent secret key showing before blurred ([6929ada](6929ada)) * refactor JSX namespace to React.JSX ([4a07bcb](4a07bcb)) * retore form state, chromium ([be3204d](be3204d)) * secret key input, closes [#3954](#3954) ([5f000ba](5f000ba)) * stacks nfts loading key not unique, closes [#3789](#3789) ([dad5d6e](dad5d6e)) * upgrade packages ([74f6d25](74f6d25)) * use routes over state for home tabs, closes [#3518](#3518) ([cb2f317](cb2f317)) * use windows friendly syntax so that yarn dev will launch on windows machines ([56b6778](56b6778)) ### Internal * keychain ([c5d4761](c5d4761)) * migrate to manifest version 3 ([03dbb1e](03dbb1e)) * mv3 fix ([0f54a1f](0f54a1f)) * restore gaia functionality ([bf136dc](bf136dc)) * sending max fees, closes [#3871](#3871) ([90c1c31](90c1c31)) * stacks keychain logic ([846132b](846132b)) * upgrade packages ([d3978f0](d3978f0)) * upgrade packages, p1 ([cb7da02](cb7da02)) * upgrade packages, p2 ([51b7da0](51b7da0))
blockstack-devops
pushed a commit
that referenced
this issue
Jul 25, 2023
## [6.0.0](v5.0.0...v6.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * this change is sufficient enough to warrant a major bump ### Features * added bitcoin contract request page ([83cf049](83cf049)) * added use-bitcoin-contract hook and additional functions and configs ([626ef0b](626ef0b)) * extended rpcmethods with bitcoin contract related case, added routes and success/failure pages ([f0ff7af](f0ff7af)) * manifest v3 release trigger ([80615ca](80615ca)) ### Bug Fixes * added back dlc-wasm-wallet package ([ba27aaf](ba27aaf)) * added working package.json ([e8067d0](e8067d0)) * cross install tracking ([3bc59ac](3bc59ac)) * fixed frozen lockfile ([536aeec](536aeec)) * made requested css and const changes ([8846e0e](8846e0e)) * modified bitcoin contract request ui (width, size, weight) ([36d7c80](36d7c80)) * modified yarn lock file ([52b1d14](52b1d14)) * multi extension loading ([03465c0](03465c0)) * only show errors when field not in focus, closes [#3766](#3766) ([abffd71](abffd71)) * ran prettier formatting ([16ca959](16ca959)) * ran prettier formatting ([515b1e5](515b1e5)) * remove warning banner ([b3427bf](b3427bf)) * type errors ([a2598a9](a2598a9)) * unprocessable pending txs balance subtraction, closes [#3921](#3921) ([2d284db](2d284db)) ### Internal * **release:** 4.36.0 ([8184b75](8184b75)), closes [#3989](#3989) [#3921](#3921) [#2330](#2330) [#3954](#3954) [#3789](#3789) [#3518](#3518) [#3871](#3871) * **release:** 5.0.0 ([0e73a1e](0e73a1e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When landing on a clean wallet install, the welcome page appears (briefly) before insta-navigating to the analytics consent page.
This is because the implementation only checks whether consent has been given on the welcome page itself. This logic should be moved to the routing level, so that on clean install, a wallet always begin the routing flow on this page.
The text was updated successfully, but these errors were encountered: