Skip to content

Conversation

Prashant-thakur77
Copy link
Contributor

@Prashant-thakur77 Prashant-thakur77 commented Oct 1, 2025

Fixes #5410

Summary

Migrated 5 channel action confirmation dialogs from Vuetify to KDS KModal

Changed title of the soft delete button from"Permanently delete channel" to "delete channel" for proper distinction (after confirming from misrob)

After images for Desktop users:

Screenshot From 2025-10-01 17-33-08 Screenshot From 2025-10-01 17-33-20 Screenshot From 2025-10-01 17-33-25 Screenshot From 2025-10-01 17-33-28 Screenshot From 2025-10-01 17-33-31

After images for Mobile users:

Screenshot From 2025-10-01 17-17-06 Screenshot From 2025-10-01 17-17-16 Screenshot From 2025-10-01 17-17-24 Screenshot From 2025-10-01 17-18-05

References

• Parent issue: #5060

Reviewer guidance

Login as a@a.com with password a
Go to Administration > Channels
Click Actions dropdown in the last column of the table
Click Make public / Make private / Delete channel / Restore / Delete pernamently (note that availability of these options depends on channel type).

@Prashant-thakur77
Copy link
Contributor Author

Prashant-thakur77 commented Oct 1, 2025

Hi @MisRob,

I've updated the ChannelActionsDropdown.spec.js tests (Locally) after migrating to KModal as i saw the tests failing.

Changes:
Updated event names from 'confirm' to 'submit' (KModal uses different events).
Added dialog activation steps (KModal uses v-if and needs to be rendered first).
All tests now pass (Only checked by locally running the unit-test file).

Let me know if you have any feedback and then i will update the Pr.

@MisRob
Copy link
Member

MisRob commented Oct 3, 2025

Thank you @Prashant-thakur77, we will assign a reviewer next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Delete, restore, and visibility confirmation dialogs in admin channel actions
2 participants