Refactor 'unsaved changes' modal to use KModal component and update tests #5306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kartikayy007
changed the title
Kartikayy007
changed the title
|
Thank you @Kartikayy007, we will assign a reviewer next week. |
LianaHarris360
requested changes
Aug 29, 2025
There was a problem hiding this comment.
There just a few items that need to be cleaned up, but otherwise these changes are looking good, thank you @Kartikayy007!
| import { set } from 'vue'; | ||
| import { mapGetters, mapActions } from 'vuex'; | ||
| import difference from 'lodash/difference'; | ||
| import KModal from 'kolibri-design-system/lib/KModal'; |
There was a problem hiding this comment.
We don't have to import KModal from KDS, this line can be removed :)
| MessageDialog, | ||
| ChannelItem, | ||
| FullscreenModal, | ||
| KModal, |
There was a problem hiding this comment.
Likewise, this line should be removed, we don't need to insert KModal as a child component.
| } | ||
| }, | ||
| confirmCancel() { | ||
| this.showUnsavedDialog = false; |
There was a problem hiding this comment.
showUnsavedDialog is set to false within this.close(), which is called in this function already, so we don't need this line added here.
|
@Kartikayy007 are you planning to resolve feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced Vuetify's
MessageDialogcomponent with Kolibri Design System'sKModalfor the unsaved changes dialog in the Collections modal.MessageDialogwithKModalinChannelSetModal.vueKModal's API (title,submitText,cancelText)Manual verification:
user@a.comwith passwordaKModalstylingReferences
Reviewer Guidance
Test these changes by:
user@a.comwith passwordaAreas to focus on:
channelSetModal.spec.jspass