Skip to content

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 22, 2024

Summary

Description of the change(s) you made

This is a copy of the action we use in Kolibri.

@vkWeb will later on explore if we can extract some common logic. For now, we agreed it's okay to copy it so we can receive notifications soon.

Note that before we merge, Studio needs to be granted access to organization-level Slack secret. @rtibbles could you please allow it?

Reviewer guidance

How can a reviewer test these changes?

If code looks correct, we can merge and see.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice @MisRob, good work!

@rtibbles I think we need to set up SLACK_WEBHOOK_URL on studio as well? Once that's set up, this can be merged.

@MisRob
Copy link
Member Author

MisRob commented Feb 27, 2024

Currently blocked by attempts to fix the original Kolibri action. Let's wait.

@MisRob MisRob merged commit 91dfec0 into learningequality:unstable Mar 6, 2024
@akolson akolson mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants