Skip to content

Conversation

jredrejo
Copy link
Member

Summary

Upgrade le-utils to the latest version of this package.
Studio unstable is using 0.2.1.
Support for scorm files was added in 0.2.2.

This PR is done to have the option to upload scorm files.

Reviewer guidance

Studio should be working fine after this update.

References

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo requested review from bjester and rtibbles February 21, 2024 19:38
@bjester
Copy link
Member

bjester commented Feb 22, 2024

@jredrejo the ./contentcuration/manage.py makemigrations --check failed. The upgrade of the le-utils package will require some migrations to be generated

@bjester bjester self-assigned this Feb 22, 2024
@jredrejo
Copy link
Member Author

@jredrejo the ./contentcuration/manage.py makemigrations --check failed. The upgrade of the le-utils package will require some migrations to be generated

@bjester thanks, I just wanted to notice the need of this upgrade to test the experimental scorm support. I suppossed something else was going to be needed but could not spend time on it. This is not urgent for me now and I have some things to be done asap. In case you can take it over, perfect. If not, I'll continue it in the upcoming iterations.

@rtibbles
Copy link
Member

I decided I want my ricecooker PR tested and merged, so I jumped in here :)

@rtibbles rtibbles merged commit 6e3be57 into learningequality:unstable Mar 22, 2024
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants