Fix glob sync query #923
Merged
Fix glob sync query #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVelezLl
requested a deployment
to
percy_tests
GitHub Actions
Waiting
|
For reference, I will link #823 |
MisRob
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
All good, thank you @AlexVelezLl for fixing KDS on so many fronts today :)!
|
Oh yes, it was #823 😆, IDK why I linked another unrelated PR hahaha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #823, we removed the
globbypackage in favor ofnode-glob, but it seems that due to a version mismatch we were usingconst { GlobSync } = require('glob');as the api, but it wasnt working well and when querying the files, it wasnt finding any, and the jsdocs result was an empty object that made our component docs to miss the API info:This PR fixes this using
glob.syncinstead as suggested in their docs (and suggested by copilot 😅).Changelog
Steps to test
yarn devand check that the API sections (props, events, slots) are present in component docs