Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the type displayed instead of migration name with migrate-list #206

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Fix the type displayed instead of migration name with migrate-list #206

merged 2 commits into from
Jun 7, 2023

Conversation

samirsilwal
Copy link
Collaborator

@samirsilwal samirsilwal commented Jun 7, 2023 •
edited by mesaugat
Loading

Changes

image

  • The result of running the migration list returns data as above now. Previously, it used to be just the array of names
  • I am not sure about the cause, but don't see any related changes in recent commits

After fix

image

Fixes #204

@samirsilwal samirsilwal self-assigned this Jun 7, 2023
@mesaugat
Copy link
Member

mesaugat commented Jun 7, 2023

@samirsilwal If this works, we can change the base branch to fix/remove-error-log-when-dir-does-not-exist. Trying to make a 2.0.1 release there.

@samirsilwal
Copy link
Collaborator Author

@samirsilwal If this works, we can change the base branch to fix/remove-error-log-when-dir-does-not-exist. Trying to make a 2.0.1 release there.

Yeah it works, i will finalize the PR

@samirsilwal samirsilwal marked this pull request as ready for review June 7, 2023 11:34
@samirsilwal
Merge branch 'fix/remove-error-log-when-dir-does-not-exist' of github…
08319be 
….com:leapfrogtechnology/sync-db into fix/migration-list
@samirsilwal samirsilwal changed the base branch from master to fix/remove-error-log-when-dir-does-not-exist June 7, 2023 11:36
@samirsilwal samirsilwal changed the title Fix the type displayed instead of string in migrate-list Fix the type displayed instead of migration name in migrate-list Jun 7, 2023
@samirsilwal samirsilwal changed the title Fix the type displayed instead of migration name in migrate-list Fix the type displayed instead of migration name with migrate-list Jun 7, 2023
mesaugat
mesaugat approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mesaugat
Copy link
Member

mesaugat commented Jun 7, 2023

@samirsilwal Should we do the same for remaining migration list?

@samirsilwal
Copy link
Collaborator Author

@samirsilwal Should we do the same for remaining migration list?

The remaining are array of string so it works with current code

@mesaugat mesaugat merged commit c0ebfcd into fix/remove-error-log-when-dir-does-not-exist Jun 7, 2023
@mesaugat mesaugat deleted the fix/migration-list branch June 7, 2023 12:04
@samirsilwal samirsilwal mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesaugat mesaugat mesaugat approved these changes

@silwalanish silwalanish Awaiting requested review from silwalanish

@kshitish182 kshitish182 Awaiting requested review from kshitish182

Assignees

@samirsilwal samirsilwal

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[object object] seen while getting migration lists
2 participants
@samirsilwal @mesaugat