Upgrade knex(v2.4.2) and typescript(v5.0.4) to latest version
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
|
@kshitish182 One suggestion. Can we separate the core changes from the example changes? Let's create another PR just for the example changes. |
kshitish182
force-pushed
the
master
branch
2 times, most recently
from
2b983b0 to
47088ef
Compare
|
@kshitish182 I still see changes in the example directory. Can you take a look? |
I have reverted those changes. I have left one file change as it is since it was basically a bug fix. |
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 27, 2023
mesaugat
reviewed
Apr 28, 2023
| @@ -58,7 +59,7 @@ export async function loadConfig(configFilename: string = CONFIG_FILENAME): Prom | |||
|
|
|||
| log('Resolved config file.'); | |||
|
|
|||
| const loaded = mergeDeepRight(DEFAULT_CONFIG, loadedConfig) as Configuration; | |||
| const loaded = mergeDeepRight<Configuration, Configuration>(DEFAULT_CONFIG, loadedConfig); | |||
mesaugat
reviewed
Apr 28, 2023
mesaugat
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
knex(v2.4.2)andtypescript(v5.0.4)to latest versionStuffs done
kneximportsmssqlbased on the respective update onknexI have tested all the major features on the example apps and everything looks good. Ran the tests locally as well and all passed.