Show NST/ERC1948 tokens on the Bridge UI #214

troggy · 2019-05-22T13:56:30Z

Context:
All the tokens registered with the Leap Network receive a "color", a number from 0 — 655326 space. This color is being used in transactions to designate the token used by the transaction. The color space is split between tokens of different types like this:

[0 ... 32768] — ERC20 tokens
[32769 ... 49152] — NFT/ERC721
[49153 ... 65536] — NST/ERC1948

Bridge UI shows the tokens registered on the network by reading them from contract. To get them, it checks if the color is taken by querying them one by one starting from the left boundary of the color space (e.g. 32769 for NFTs):

bridge-ui/src/stores/tokens.ts

Lines 123 to 133 in de34699

    
           // load new tokens for ERC20 and ERC721 color ranges 
        
           const tokens = Promise.all([ 
        
             ...this.loadTokenColorRange( 
        
               this.erc20TokenCount, 
        
               erc20TokenCount - 1 
        
             ), 
        
             ...this.loadTokenColorRange( 
        
               NFT_COLOR_BASE + this.nftTokenCount, 
        
               NFT_COLOR_BASE + nftTokenCount - 1 
        
             ), 
        
           ]);

Problem:
Reading NST color space from the contract is not implemented. So even if you register an NST it won't be visible on bridge UI.

To do:

Make NSTs should be visible on a Register token page
Make token page in Explorer work for NST
Do not show NSTs on a wallet page. They are not meant to be transferred manually

Optional (extra tips if any of these is complete as well):

Explorer: NST transactions should be displayed correctly
something else which makes sense in the context of the issue

Environment for test:
As of now, there is an NST token registered with a testnet, which is not visible on Bridge UI. To run the bridge UI with this network use CONFIG=testnet yarn start.

The text was updated successfully, but these errors were encountered:

gitcoinbot · 2019-05-23T08:09:11Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 150.0 DAI (150.0 USD @ $1.0/DAI) attached to it as part of the LeapDAO fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$82,492.90 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot · 2019-05-23T08:10:29Z

Issue Status: 1. Open 2. Cancelled

Workers have applied to start work.

These users each claimed they can complete the work by 2 years, 8 months ago.
Please review their action plans below:

1) iamonuwa has applied to start work (Funders only: approve worker | reject worker).

Spending my weekend on this task. ETA is before Sunday

Learn more on the Gitcoin Issue Details page.

pbteja1998 · 2019-05-26T09:02:52Z

@troggy is this issue still available?

troggy · 2019-05-26T09:40:12Z

@pbteja1998 Gitcoin seemed to have some issues with this bounty — it appeared that I could only approve iamonuwa or travisdmathis, but not the other two people including you, unfortunately. I've posted at issue for Gitcoin here (gitcoinco/web#4486).

I will post more bounties next week, you are very welcome to apply 🙏

troggy · 2019-05-26T09:46:13Z

@pbteja1998 if you are interested to get involved in LeapDAO community, please join our Slack: https://docs.google.com/forms/d/e/1FAIpQLSd8_wDGDAi__HvfYEWNK_bvJzIkxwHHRVL6AFEfJewBd2Vn9A/viewform

We are interested in attracting long term contributors and have much more work to do, though we are posting only easier things to Gitcoin.

pbteja1998 · 2019-05-26T10:09:25Z

@troggy I have joined the slack. Can you tell me which channels should I join specifically?

pbteja1998 · 2019-05-26T10:13:16Z

Should I stop work in gitcoin for this issue?

pbteja1998 · 2019-05-27T08:41:31Z

@troggy I am having problems with setting up the project. I am getting No Connection to Leap Node after starting.

Is there something else that needs to be configured?

troggy · 2019-05-27T10:20:13Z

Should I stop work in gitcoin for this issue?

@pbteja1998 yes, please. Unless @travisdmathis isn't changed his mind to work on this issue

pbteja1998 · 2019-05-27T11:43:24Z

Ok, I have stopped work on gitcoin.

@troggy I have joined the slack. Can you tell me which channels should I join specifically?

What about this?

troggy · 2019-05-27T14:25:48Z

@pbteja1998 you can start with #new_contributors or jump in #20_d_for_development right away. Please reach out to @kohola on Slack if you ever feel lost — we are trying to stay organized, but it may still be confusing 🙏

travisdmathis · 2019-05-27T22:08:25Z

@troggy i'm happy to take care of it for you, just approve it on gitcoin and i'll take it over.

troggy · 2019-05-28T04:15:03Z

@travisdmathis should be already approved. Can you double check?

travisdmathis · 2019-05-28T11:48:28Z

@troggy ya, it looks like there's a gitcoin bug happening.. I never got a notification that i was approved, it shows me as "work started" up top but it doesn't show me as worker approved, still says I just submitted a request for approval here.. It's actually showing Kevin as approved for work for me? https://gitcoin.co/issue/leapdao/bridge-ui/214/3040 Not sure what's going on there, but i'll get to work on it this week 👍 and get it back to you.

…

On Tue, May 28, 2019 at 12:15 AM Kosta Korenkov ***@***.***> wrote: @travisdmathis <https://github.com/travisdmathis> should be already approved. Can you double check? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#214?email_source=notifications&email_token=AAKF7HQZ4LD2MRZV34HTEP3PXSWUPA5CNFSM4HOUSYK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWK5LWQ#issuecomment-496358874>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKF7HWIESDYQSFOV4LABXTPXSWUPANCNFSM4HOUSYKQ> .

-- Thank you, Travis Mathis

gitcoinbot · 2019-05-31T16:16:16Z

@travisdmathis Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

troggy · 2019-05-31T17:06:07Z

@travisdmathis ~~I've registered NST on testnet. Token address: 0x26a937302cc6A0A7334B210de06136C8C61BA885~~

UPD: well, hasn't been really registered. Investigating..

UPD2: it's in the bridge. Color 49153. So can be used for the purposes on this issue. Good luck

troggy · 2019-06-06T05:04:05Z

@travisdmathis What's the status? Please submit WIP PR (at least) before Friday end of the day. Otherwise I will have to withdraw this one from you

troggy · 2019-06-12T13:33:14Z

Hey @pbteja1998. Still interested in this bounty? It is available now — apply on Gitcoin

troggy · 2019-06-21T12:34:25Z

@ericramos1980 👋Are you still interested? If so, please apply again (due to issue with Gitcoin your application is no active anymore)

gitcoinbot · 2019-07-09T17:25:06Z

Issue Status: 1. Open 2. Cancelled

The funding of 150.0 DAI (150.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

Questions? Checkout Gitcoin Help or the Gitcoin Slack
$136,336.43 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot · 2019-07-09T17:25:16Z

Issue Status: 1. Open 2. Cancelled

The funding of 150.0 DAI (150.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

Questions? Checkout Gitcoin Help or the Gitcoin Slack
$136,336.43 more funded OSS Work available on the Gitcoin Issue Explorer

troggy added bounty size-XS effort of ~3h labels May 23, 2019

troggy changed the title ~~support NST/ERC1948~~ Show NST/ERC1948 tokens on the Bridge UI May 23, 2019

johannbarbie mentioned this issue Jun 28, 2019

add support for NSTs #231

Merged

troggy closed this as completed in #231 Jul 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show NST/ERC1948 tokens on the Bridge UI #214

Show NST/ERC1948 tokens on the Bridge UI #214

troggy commented May 22, 2019 •

edited by johannbarbie

Loading

gitcoinbot commented May 23, 2019

gitcoinbot commented May 23, 2019 •

edited

Loading

pbteja1998 commented May 26, 2019

troggy commented May 26, 2019

troggy commented May 26, 2019

pbteja1998 commented May 26, 2019

pbteja1998 commented May 26, 2019

pbteja1998 commented May 27, 2019

troggy commented May 27, 2019

pbteja1998 commented May 27, 2019

troggy commented May 27, 2019 •

edited

Loading

travisdmathis commented May 27, 2019

troggy commented May 28, 2019

travisdmathis commented May 28, 2019 via email •

edited

Loading

gitcoinbot commented May 31, 2019

troggy commented May 31, 2019 •

edited

Loading

troggy commented Jun 6, 2019

troggy commented Jun 12, 2019 •

edited

Loading

troggy commented Jun 21, 2019

gitcoinbot commented Jul 9, 2019

gitcoinbot commented Jul 9, 2019

Show NST/ERC1948 tokens on the Bridge UI #214

Show NST/ERC1948 tokens on the Bridge UI #214

Comments

troggy commented May 22, 2019 • edited by johannbarbie Loading

gitcoinbot commented May 23, 2019

gitcoinbot commented May 23, 2019 • edited Loading

pbteja1998 commented May 26, 2019

troggy commented May 26, 2019

troggy commented May 26, 2019

pbteja1998 commented May 26, 2019

pbteja1998 commented May 26, 2019

pbteja1998 commented May 27, 2019

troggy commented May 27, 2019

pbteja1998 commented May 27, 2019

troggy commented May 27, 2019 • edited Loading

travisdmathis commented May 27, 2019

troggy commented May 28, 2019

travisdmathis commented May 28, 2019 via email • edited Loading

gitcoinbot commented May 31, 2019

troggy commented May 31, 2019 • edited Loading

troggy commented Jun 6, 2019

troggy commented Jun 12, 2019 • edited Loading

troggy commented Jun 21, 2019

gitcoinbot commented Jul 9, 2019

gitcoinbot commented Jul 9, 2019

troggy commented May 22, 2019 •

edited by johannbarbie

Loading

gitcoinbot commented May 23, 2019 •

edited

Loading

troggy commented May 27, 2019 •

edited

Loading

travisdmathis commented May 28, 2019 via email •

edited

Loading

troggy commented May 31, 2019 •

edited

Loading

troggy commented Jun 12, 2019 •

edited

Loading