Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: failing macros to show error from first registered rule #3771

Merged
merged 4 commits into from
Mar 26, 2024
Merged

feat: failing macros to show error from first registered rule #3771

merged 4 commits into from
Mar 26, 2024

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Mar 26, 2024

fixes #3770

Also start rfl with a fail message that is hopefully more helpful
than what we get now (see updated test output). This would be a cheaper
way to address #3302 without changing the implementation of rfl (as
tried in #3714).

@nomeata
feat: failing macros to show error from first registered rule
eade05a 
fixes #3770

Also start `rfl` with a `fail` message that is hopefully more helpful
than what we get now (see updated test output). This would be a cheaper
way to address #3302 without changing the implementation of rfl (as
tried in #3714).
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 26, 2024 09:49 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 26, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3771
036fd41
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 26, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3771
9ff6461
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 26, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Mar 26, 2024 •
edited
Loading

Mathlib CI status (docs):

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 26, 2024 11:03 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 26, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3771
f0e64de
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 26, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3771
4ee0f3d
@nomeata nomeata marked this pull request as ready for review March 26, 2024 13:34
nomeata
nomeata commented Mar 26, 2024
View reviewed changes
src/Init/Tactics.lean Outdated Show resolved Hide resolved
nomeata
nomeata commented Mar 26, 2024
View reviewed changes
src/Init/Tactics.lean Outdated Show resolved Hide resolved
@nomeata nomeata added the will-merge-soon …unless someone speaks up label Mar 26, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 26, 2024 13:49 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 26, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3771
58d2881
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 26, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3771
a51cf39
@nomeata nomeata added this pull request to the merge queue Mar 26, 2024
Merged via the queue into master with commit 301dd7b Mar 26, 2024
13 of 19 checks passed
@nomeata nomeata deleted the joachim/macro-last-error branch March 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison Awaiting requested review from semorrison semorrison is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: macros should show last error, not first
2 participants
@nomeata @leanprover-community-mathlib4-bot