feat: a minimalistic port of compute_degree_le
#6007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
changed the title
compute_degree_leAdd minimal tactic and several testscompute_degree_le
1 task
adomani
added
awaiting-review
modifies-tactic-syntax
|
I am closing this PR since #6221 ports more functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #5882. It gives a "minimalistic" port of the
compute_degree_letactic.This very short tactic works on all tests.
The other PR is more structured and is probably further along the direction of a more complete implementation of acompute_degreetactic.In the long run, I think that the definitions in the other tactic will likely make up thecompute_degreetactic, but they are not needed for the easiercompute_degree_letactic.PR #6221 implements the full
compute_degreetactic with a method similar to the one in this PR. I am tempted to close this PR, except for the fact that it might be a possible stepping stone to get to the full implementation.